introduce start-period and start-interval parameters to HEALTHCHECK #547
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- start period allows for a grace period for the container to boot - start-interval allows for more frequent checking during this grace period - also slightly increased the standard interval once the container is healthy
Member
|
Sorry for the hiccup here, but could you try creating a new PR? I had to move things in GitHub it automatically closed this PR. I don't see where I can update the branch into https://github.com/serversideup/docker-php/tree/280-create-a-frankenphp-variation It won't let me change it when I press edit. |
jaydrogers
changed the base branch from
release/v3.6
to
280-create-a-frankenphp-variation
Member
|
NVM, I got it. I accidentally deleted the source branch. That's why it closed. I will be reviewing this for 4.0 and will keep you posted 👍 Sorry for the confusion! |
Member
|
I love this proposal! Thanks a ton for sharing this, I learned a lot. I summarized the changes here. Your proposal is brilliant 💯
|
jaydrogers
merged commit ad5fe47
into
serversideup:280-create-a-frankenphp-variation
12 of 86 checks passed
github-project-automation
bot
moved this from 🤔 Evaluating
to Done
in serversideup/php v4.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #541
See my comment for reasoning behind the values I've chosen.